Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/ --- (Updated June 17, 2013, 7:53 p.m.) Status -- This change has been mar

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/#review34529 --- This review has been submitted with commit 150b19d61dd1e7ce30b

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Alexander Neundorf
> On June 17, 2013, 6:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wrote: > The syntax seems to

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wrote: > The syntax seems to

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. > > Albert Astals Cid wrote: > The syntax seems to

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/#review34515 --- Ship it! Ship It! - Alexander Neundorf On June 17, 2013, 3:

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Albert Astals Cid
> On June 17, 2013, 6:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? > > Andrea Scarpino wrote: > Those are available in the upstream FindGettext too. The syntax seems to be a bit different :-/ -# GETTEXT_

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
> On June 17, 2013, 8:13 p.m., Albert Astals Cid wrote: > > What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or > > GETTEXT_PROCESS_PO_FILES? Those are available in the upstream FindGettext too. - Andrea --- This is an autom

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/#review34508 --- What about the other stuff like GETTEXT_CREATE_TRANSLATIONS or

Re: Review Request 111068: Drop internal Msgfmt cmake module

2013-06-17 Thread Andrea Scarpino
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111068/ --- (Updated June 17, 2013, 5:26 p.m.) Review request for kdelibs and Alexande