Re: Review Request 110367: Add JoinTheGame menu entry

2013-06-09 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/ --- (Updated June 9, 2013, 10:27 a.m.) Status -- This change has been dis

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-18 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/#review32763 --- This caused an unhandled switch warning in kdoctools/genshortcu

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-18 Thread Ben Cooksley
> On May 18, 2013, 1:33 p.m., Albert Astals Cid wrote: > > ShipIt from anyone? Code looks fine from my point of view. I'm not the maintainer of kdeui though, so I won't give it a ship it for now. - Ben --- This is an automatically gener

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-18 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/#review32735 --- ShipIt from anyone? - Albert Astals Cid On May 9, 2013, 11:0

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-09 Thread Sebastian Kügler
On Thursday, May 09, 2013 15:07:20 Aaron J. Seigo wrote: > * It would be very sensible to have something in the URL that lets us > identify that the visitor has come from the about dialog. e.g. a unique url > such as http://jointhegame.kde.org/?from=inapp or whatever makes sense. Or maybe even "fr

Re: Review Request 110367: Add JoinTheGame menu entry

2013-05-09 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/#review32282 --- I think this is fine to go in, however two comments: * This mu

Review Request 110367: Add JoinTheGame menu entry

2013-05-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110367/ --- Review request for kdelibs. Description --- Patch by Pau ages ago, Ly