Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/110083/ --- (Updated Jan. 20, 2015, 4:24 p.m.) Status -- This change has been di

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review32318 --- CMakeLists.txt

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review32310 --- Ship it! Ship It! - Kevin Krammer On May 10, 2013, 10:32 a.

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/ --- (Updated May 10, 2013, 10:32 a.m.) Review request for kdelibs and KDEPIM-L

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review32015 --- libkfbapi/userinfo.h

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/ --- (Updated May 4, 2013, 9:34 a.m.) Review request for kdelibs and KDEPIM-Lib

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

> On May 3, 2013, 10:35 a.m., Kevin Krammer wrote: > > libkfbapi/kdepim-utils.cpp, line 30 > > > > > > Hmm. I see the same value being defined in userinfo.cpp so maybe it > > should be a public const int or enum v

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31934 --- libkfbapi/kdepim-utils.cpp

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/ --- (Updated May 3, 2013, 9:41 a.m.) Review request for kdelibs and KDEPIM-Lib

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

> On May 2, 2013, 8:49 a.m., Christophe Giboudeaux wrote: > > LibKFbAPI-KDEPIMConfig.cmake.in, line 24 > > > > > > CMake will stop at this point. > > > > Exported targets can only be loaded once. > >

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

> On May 3, 2013, 6:43 a.m., Kevin Krammer wrote: > > libkfbapi/kdepim-utils.cpp, line 4 > > > > > > how do you arrive at this value? is this documented somewhere? 42 is the universal answer for everything! Besides

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31926 --- CMakeLists.txt

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

> On May 2, 2013, 8:49 a.m., Christophe Giboudeaux wrote: > > LibKFbAPI-KDEPIMConfig.cmake.in, line 24 > > > > > > CMake will stop at this point. > > > > Exported targets can only be loaded once. > >

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31872 --- LibKFbAPI-KDEPIMConfig.cmake.in

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31870 --- Ping? - Martin Klapetek On April 29, 2013, 11:18 a.m., Marti

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/ --- (Updated April 29, 2013, 11:18 a.m.) Review request for kdelibs and KDEPIM

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/ --- (Updated April 29, 2013, 11:17 a.m.) Review request for kdelibs and KDEPIM

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

> On April 26, 2013, 8:09 a.m., Kevin Krammer wrote: > > I am wondering if it wouldnt't make more sense to have the PIM integration > > as a separate lib, so that libkfbapi has a stable API and ABI at all times. I like that idea. I'll update the review with it then :) - Martin -

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/#review31608 --- I am wondering if it wouldnt't make more sense to have the PIM

Re: Review Request 110083: Make kdepim libs optional dependency for libkfbapi

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110083/ --- (Updated April 26, 2013, 7:37 a.m.) Review request for kdelibs and KDEPIM-