Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-07-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review35800 --- Important: the bug is not fixed forever. In Qt5, QFile::setEnco

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review35344 --- This review has been submitted with commit f4269ef3498581964e8

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-07-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated July 1, 2013, 10:55 a.m.) Status -- This change has been mar

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread Thiago Macieira
> On June 28, 2013, 2:53 p.m., David Faure wrote: > > Independently from this patch, I was thinking of a completely different > > approach to solve non-utf8 encodings in file:/// urls: using > > KRemoteEncoding in kio_file, just like we do in other slaves like kio_ftp. > > I.e. letting the use

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review35232 --- Independently from this patch, I was thinking of a completely d

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread Róbert Szókovács
> On June 28, 2013, 12:44 p.m., Dawit Alemayehu wrote: > > Have you committed this yet? I do not see it in git master. Anyhow, can you > > please add "BUG: 159241" to your commit message when you do push it in? > > That bug report is the original one for the encoding issue you were trying > >

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review35221 --- Have you committed this yet? I do not see it in git master. Any

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-28 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated June 28, 2013, 9:28 a.m.) Status -- This change has been mar

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-14 Thread Róbert Szókovács
> On June 5, 2013, 10:35 a.m., Róbert Szókovács wrote: > > Would anybody please take a look at the latest version and comment? I'd like to push it into 4.11, if possible, please someone with authority say the word. - Róbert --- This is

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-06-05 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review33783 --- Would anybody please take a look at the latest version and comm

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-22 Thread Róbert Szókovács
> On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: > > The solution is intentionally "shy", I really don't want to fan the flames > > surrounding this issue. I just stumbled upon this location when it can be > > handled painlessly. Whether or not it should be turned on by default, in my > >

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-17 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 17, 2013, 10:08 a.m.) Review request for kdelibs and Thiago M

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-17 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 17, 2013, 10:07 a.m.) Review request for kdelibs and Thiago M

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-15 Thread Róbert Szókovács
> On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: > > The solution is intentionally "shy", I really don't want to fan the flames > > surrounding this issue. I just stumbled upon this location when it can be > > handled painlessly. Whether or not it should be turned on by default, in my > >

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-10 Thread Thomas Lübking
> On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: > > The solution is intentionally "shy", I really don't want to fan the flames > > surrounding this issue. I just stumbled upon this location when it can be > > handled painlessly. Whether or not it should be turned on by default, in my > >

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-10 Thread Róbert Szókovács
> On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: > > The solution is intentionally "shy", I really don't want to fan the flames > > surrounding this issue. I just stumbled upon this location when it can be > > handled painlessly. Whether or not it should be turned on by default, in my > >

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 7, 2013, 4:14 p.m.) Review request for kdelibs and Thiago Mac

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 7, 2013, 2:25 p.m.) Review request for kdelibs and Thiago Mac

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Thomas Lübking
> On May 7, 2013, 10:11 a.m., Róbert Szókovács wrote: > > The solution is intentionally "shy", I really don't want to fan the flames > > surrounding this issue. I just stumbled upon this location when it can be > > handled painlessly. Whether or not it should be turned on by default, in my > >

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review32184 --- The solution is intentionally "shy", I really don't want to fan

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-07 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 7, 2013, 10:04 a.m.) Review request for kdelibs and Thiago Ma

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-05 Thread Thiago Macieira
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review32093 --- I don't like it. There's a reason why I removed the equivalent

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review32055 --- this is kinda getting old ... just two links to discussions i w

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- (Updated May 5, 2013, 8:13 a.m.) Review request for kdelibs and Thiago Mac

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-05-01 Thread Róbert Szókovács
> On April 16, 2013, 5:15 p.m., Christoph Feck wrote: > > Nice idea, would be better to use Unicode Private Use Areas instead of > > 0x18000 codes. I've been considering that, too. I don't think it's very likely that someone will legitimely use neither the PUA or any currently unassigned area

Re: Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-04-16 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/#review31172 --- Nice idea, would be better to use Unicode Private Use Areas ins

Review Request 110043: Proposed fix/workaround for legacy encoded filename handling

2013-04-16 Thread Róbert Szókovács
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110043/ --- Review request for kdelibs. Description --- This patch works around t