Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27273 --- Ship it! Ship It! - David Faure On Feb. 12, 2013, 4 a.m., S

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- (Updated Feb. 12, 2013, 4 a.m.) Review request for kdelibs, Plasma and Dav

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Thiago Macieira
On segunda-feira, 11 de fevereiro de 2013 16.13.16, David Faure wrote: > Well, this isn't Qt. We can install our stuff where-ever we want, as long as > the right env var points to it (I forgot the name, but I was told there's > such an env var for qtquick2 stuff). But yeah, same defaults can make t

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread David Faure
On Monday 11 February 2013 18:02:39 Sebastian Kügler wrote: > Do we have any canonical place where I set a sensible the QML2_IMPORT_PATH > env var, so we don't have to tell everybody to add this to their setup? The current solution is to document it in http://community.kde.org/Frameworks/Buildin

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Alexander Neundorf
On Sunday 10 February 2013, Sebastian Kügler wrote: > > On Feb. 10, 2013, 3:40 p.m., David Faure wrote: > > > kde-modules/KDEInstallDirs.cmake, line 136 > > > > > line136> > > > > > > For an install prefix in /usr, this

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
On Monday, February 11, 2013 17:43:01 Stephen Kelly wrote: > Sebastian Kügler wrote: > >> What do you need it for, exactly? > > > > To find out where Qt will look for QtQuick2 imports (that's > > $ARCHDATADIR/qml, defaulting to $PREFIX/qml, which leads to /usr/qml). > > > > I'd like to be able to

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Stephen Kelly
Sebastian Kügler wrote: >> What do you need it for, exactly? > > To find out where Qt will look for QtQuick2 imports (that's > $ARCHDATADIR/qml, defaulting to $PREFIX/qml, which leads to /usr/qml). > > I'd like to be able to install Plasma QtQuick2 imports into a path where > they'll actually be

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread David Faure
> On Feb. 10, 2013, 3:40 p.m., David Faure wrote: > > kde-modules/KDEInstallDirs.cmake, line 136 > > > > > > For an install prefix in /usr, this would make it /usr/qml ... is this > > really wanted? > > > >

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
On Monday, February 11, 2013 17:03:55 Stephen Kelly wrote: > Sebastian Kügler wrote: > > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > >> On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > >> > Apparently not. I've looked at where the example imports from the Q

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Stephen Kelly
Sebastian Kügler wrote: > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: >> On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: >> > Apparently not. I've looked at where the example imports from the Qt >> > codebase install these things, and that is indeed $PREFIX/q

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Thiago Macieira
On segunda-feira, 11 de fevereiro de 2013 12.21.48, Sebastian Kügler wrote: > On Monday, February 11, 2013 10:49:08 Sebastian Kügler wrote: > > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > > > On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > > > > Apparently

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
[adding frameworks list, slipped out] On Monday, February 11, 2013 10:49:08 Sebastian Kügler wrote: > On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > > On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > > > Apparently not. I've looked at where the example import

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-11 Thread Sebastian Kügler
On Sunday, February 10, 2013 14:33:49 Thiago Macieira wrote: > On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > > Apparently not. I've looked at where the example imports from the Qt > > codebase install these things, and that is indeed $PREFIX/qml, not inside > > the plugin

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread Thiago Macieira
On domingo, 10 de fevereiro de 2013 21.22.05, Sebastian Kügler wrote: > Apparently not. I've looked at where the example imports from the Qt > codebase install these things, and that is indeed $PREFIX/qml, not inside > the plugin directory. This location is also where these imports are being > foun

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread Sebastian Kügler
> On Feb. 10, 2013, 3:40 p.m., David Faure wrote: > > kde-modules/KDEInstallDirs.cmake, line 136 > > > > > > For an install prefix in /usr, this would make it /usr/qml ... is this > > really wanted? > > > >

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread Thiago Macieira
On domingo, 10 de fevereiro de 2013 09.37.54, Thiago Macieira wrote: > Probably not. Where does KDE install its Qt Quick 2 extensions? It should > probably be $LIBDIR/kde4/qml, not $PREFIX/qml (the Qt default). Or, in this case, since we're not talking about KDE 4, it should be something else in

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread Thiago Macieira
On domingo, 10 de fevereiro de 2013 15.40.23, David Faure wrote: > For an install prefix in /usr, this would make it /usr/qml ... is this > really wanted? Probably not. Where does KDE install its Qt Quick 2 extensions? It should probably be $LIBDIR/kde4/qml, not $PREFIX/qml (the Qt default).

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27131 --- Ship it! Looks good. - Alexander Neundorf On Feb. 10, 2013

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/#review27129 --- kde-modules/KDEInstallDirs.cmake

Re: Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- (Updated Feb. 10, 2013, 3:37 p.m.) Review request for kdelibs, Plasma and

Review Request 108889: Add QML_INSTALL_DIR variable to KDE pathes

2013-02-10 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108889/ --- Review request for kdelibs, Plasma and David Faure. Description --- T