Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review8653 --- Ship it! I have asked in kde-core-devel if adding media player

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

> On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote: > > solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109 > > > > > > We have been returning "mtp" as the protocol that identify "mtp" > > devices, the v

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

> On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote: > > solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109 > > > > > > We have been returning "mtp" as the protocol that identify "mtp" > > devices, the v

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

> On Nov. 20, 2011, 3:38 a.m., Alex Fiestas wrote: > > Oh another thing, the CMakeList should check for media-player-info as an > > optional dependency > > Matěj Laitl wrote: > OK, I'll add that. The problem is that media-player-info is runtime-only > depencency - even if not present durin

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

> On Nov. 20, 2011, 3:38 a.m., Alex Fiestas wrote: > > Oh another thing, the CMakeList should check for media-player-info as an > > optional dependency OK, I'll add that. The problem is that media-player-info is runtime-only depencency - even if not present during build, it will work if instal

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

> On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote: > > solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109 > > > > > > We have been returning "mtp" as the protocol that identify "mtp" > > devices, the v

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

> On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote: > > solid/solid/CMakeLists.txt, line 82 > > > > > > I can understand the copy/paste of this file, but do we need all of it? > > I'd rather keep only what we need an

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review8330 --- Oh another thing, the CMakeList should check for media-player-in

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review8329 --- This patch looks nice, a few things/questions though: solid/so

Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/ --- Review request for kdelibs. Description --- This is a second attempt