Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info

2012-04-28 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review13040 --- This review has been submitted with commit 3c1c788cc52e166278a

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info

2012-04-23 Thread Alex Fiestas
> On April 22, 2012, 9:36 p.m., Matěj Laitl wrote: > > Bump. Should I port this to to-be kdelibs 4.9, or is it too late? Is the patch any different? it should be just the same. In that case please, apply this patch to 4.8, 4.9 and Frameworks. - Alex -

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info

2012-04-23 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review12814 --- Bump. Should I port this to to-be kdelibs 4.9, or is it too lat

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info

2011-12-04 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/ --- (Updated Dec. 3, 2011, 11:59 p.m.) Review request for kdelibs. Changes -

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-12-02 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review8653 --- Ship it! I have asked in kde-core-devel if adding media player

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-22 Thread Matěj Laitl
> On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote: > > solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109 > > > > > > We have been returning "mtp" as the protocol that identify "mtp" > > devices, the v

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-22 Thread Alex Fiestas
> On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote: > > solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109 > > > > > > We have been returning "mtp" as the protocol that identify "mtp" > > devices, the v

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-22 Thread Alex Fiestas
> On Nov. 20, 2011, 3:38 a.m., Alex Fiestas wrote: > > Oh another thing, the CMakeList should check for media-player-info as an > > optional dependency > > Matěj Laitl wrote: > OK, I'll add that. The problem is that media-player-info is runtime-only > depencency - even if not present durin

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-22 Thread Matěj Laitl
> On Nov. 20, 2011, 3:38 a.m., Alex Fiestas wrote: > > Oh another thing, the CMakeList should check for media-player-info as an > > optional dependency OK, I'll add that. The problem is that media-player-info is runtime-only depencency - even if not present during build, it will work if instal

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-22 Thread Matěj Laitl
> On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote: > > solid/solid/backends/udev/udevportablemediaplayer.cpp, line 109 > > > > > > We have been returning "mtp" as the protocol that identify "mtp" > > devices, the v

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-21 Thread Alex Merry
> On Nov. 20, 2011, 3:37 a.m., Alex Fiestas wrote: > > solid/solid/CMakeLists.txt, line 82 > > > > > > I can understand the copy/paste of this file, but do we need all of it? > > I'd rather keep only what we need an

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-20 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review8330 --- Oh another thing, the CMakeList should check for media-player-in

Re: Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-20 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/#review8329 --- This patch looks nice, a few things/questions though: solid/so

Review Request: udev PortableMediaPlayer: read protocols from media-player-info; docs

2011-11-05 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103028/ --- Review request for kdelibs. Description --- This is a second attempt