Re: Review Request: remove an assert

2012-11-10 Thread Andras Mantia
On Tuesday, November 06, 2012 09:08:36 AM Jaime Torres Amate wrote: > > On Nov. 6, 2012, 6:46 a.m., David Edmundson wrote: > > > The responsibility of deleting d->rootDir seems to lie within KArchive. > > > Therefore by setting the rootDir twice either implicitly or explicitly > > > (which this ass

Re: Review Request: remove an assert

2012-11-06 Thread Jaime Torres Amate
> On Nov. 6, 2012, 6:46 a.m., David Edmundson wrote: > > The responsibility of deleting d->rootDir seems to lie within KArchive. > > Therefore by setting the rootDir twice either implicitly or explicitly > > (which this assert is designed to avoid) you risk leaking the first > > KArchiveDirect

Re: Review Request: remove an assert

2012-11-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107211/#review21475 --- The responsibility of deleting d->rootDir seems to lie within K

Review Request: remove an assert

2012-11-05 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107211/ --- Review request for kdelibs. Description --- I've suffered this assert