Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/#review15655 --- This review has been submitted with commit 92239b1e3f5d771325b

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-10 Thread David Faure
> On July 1, 2012, 9:14 a.m., David Faure wrote: > > Great work! > > > > I noticed a few things though: > > > > * in your initial analysis, you said KEncodingDetector had code to detect > > the encoding from the html/xml and http headers. Is this functionality lost > > during this port, in kh

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/#review15635 --- Ship it! Don't forget to move the old class to khtml, and the

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-08 Thread Hui Ni
> On July 1, 2012, 9:14 a.m., David Faure wrote: > > Great work! > > > > I noticed a few things though: > > > > * in your initial analysis, you said KEncodingDetector had code to detect > > the encoding from the html/xml and http headers. Is this functionality lost > > during this port, in kh

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-08 Thread Hui Ni
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/ --- (Updated July 9, 2012, 6:27 a.m.) Review request for kdelibs, Kevin Ottens

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-01 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/#review15285 --- Great work! I noticed a few things though: * in your initial

Review Request: remove KEncodingDetector from tier1/kcodecs

2012-06-30 Thread Hui Ni
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/ --- Review request for kdelibs, Kevin Ottens and David Faure. Description