Re: Review Request: qml based kwin shadow

2013-01-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review25138 --- This review has been submitted with commit c58962b112627de29f0

Re: Review Request: qml based kwin shadow

2013-01-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review25132 --- Ship it! the duplication tells me we should someday add a shar

Re: Review Request: qml based kwin shadow

2013-01-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 8, 2013, 12:21 a.m.) Review request for kde-workspace, kwin,

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 7:01 p.m.) Review request for kde-workspace, kwin,

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 5:49 p.m.) Review request for kde-workspace, kwin,

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
> On Jan. 7, 2013, 4:39 p.m., Martin Gräßlin wrote: > > kwin/tabbox/qml/qmldir, line 2 > > > > > > please don't include the IconTabBox in the qmldir. I consider it > > private API :-) I saw IconTabBox is used twic

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- (Updated Jan. 7, 2013, 4:07 p.m.) Review request for kde-workspace, kwin,

Review Request: qml based kwin shadow

2013-01-07 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/ --- Review request for kde-workspace, kwin, Plasma, Thomas Lübking, Aaron J. Sei

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24933 --- kwin/tabbox/qml/ShadowedSvgItem.qml

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Martin Gräßlin
> On Jan. 7, 2013, 4:39 p.m., Martin Gräßlin wrote: > > kwin/tabbox/qml/qmldir, line 2 > > > > > > please don't include the IconTabBox in the qmldir. I consider it > > private API :-) > > Xuetian Weng wrote: >

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24924 --- I need to think about whether I want to have it in org.kde.kwin

Re: Review Request: qml based kwin shadow

2013-01-07 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108243/#review24920 --- Approach seems fine to me (though I haven't tested it yet). I'm