Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-07-04 Thread Marcel Partap
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/ --- (Updated July 4, 2011, 11:29 p.m.) Review request for kdelibs and David Faur

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread Dawit A
On Tue, Jun 21, 2011 at 2:23 PM, David Faure wrote: >This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6681/ > > OK for url() then. > > Re the code above, you're probably right, it wasn't tested with > Ctrl+Shift+Tab, only with Ctrl+Tab. > > >

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/#review10246 --- OK for url() then. Re the code above, you're probably right, it

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread Marcel Partap
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/ --- (Updated June 21, 2011, 4:20 p.m.) Review request for kdelibs and David Faur

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread Dawit A
There is one particular issue with this patch. When you first start konqueror, the introduction page is shown with a blank location bar. If you then simply press escape in location bar, the location bar switches to "about:konqueror" because that is the url of the current view. Perhaps the patch nee

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/#review10245 --- Looks good, apart from some details. /trunk/KDE/kdebase/apps/ko

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-06-21 Thread Marcel Partap
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/ --- (Updated June 21, 2011, 11:26 a.m.) Review request for kdelibs and David Fau

Re: Review Request: konqueror: reset URL when pressing ESC in address bar

2011-05-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/#review10125 --- Why do this in a key press handler? It means that hitting the Sto

Review Request: konqueror: reset URL when pressing ESC in address bar

2011-05-15 Thread Marcel Partap
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6681/ --- Review request for kdelibs and David Faure. Summary --- Attempted patch