Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-05 Thread Thomas Lübking
> On Dec. 4, 2011, 6:47 p.m., Thomas Lübking wrote: > > Ok, i think i know what's wrong. > > KCategorizedView::updateGeometries() calls QListView::updateGeometries() > > which has it's own opinion on whether the scrollbars should be visible > > (valid range) or not and triggers a (sometimes add

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-05 Thread Jaime Torres Amate
> On Dec. 4, 2011, 6:47 p.m., Thomas Lübking wrote: > > Ok, i think i know what's wrong. > > KCategorizedView::updateGeometries() calls QListView::updateGeometries() > > which has it's own opinion on whether the scrollbars should be visible > > (valid range) or not and triggers a (sometimes add

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-04 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/ --- (Updated Dec. 4, 2011, 8:42 a.m.) Review request for kdelibs and Rafael Fe

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-04 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8704 --- Ok, i think i know what's wrong. KCategorizedView::updateGeometr

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-04 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8695 --- kdeui/itemviews/kcategorizedview.cpp

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-04 Thread Jaime Torres Amate
> On Dec. 3, 2011, 1:12 p.m., Ruurd Pels wrote: > > kdeui/itemviews/kcategorizedview.cpp, line 1378 > > > > > > Argh. Exit method halfway. I'd prefer reworking the trailing part of > > the function (refactoring a

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-04 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8691 --- You should add "ereslibre" in people. - Alex Fiestas On Dec.

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-03 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8688 --- kdeui/itemviews/kcategorizedview.cpp

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-03 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8683 --- Refactor it. Maybe even add a message since this might be a solu

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-03 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8682 --- kdeui/itemviews/kcategorizedview.cpp

Re: Review Request: fix infinite recurssion in kcategorizedview

2011-12-03 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/#review8681 --- Ship it! if this does indeed fix the problem, then let's ship i

Review Request: fix infinite recurssion in kcategorizedview

2011-12-03 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103313/ --- Review request for kdelibs. Description --- Basically, what I do is: