Re: Review Request: add kimgio WebP image format plugin

2012-09-10 Thread Allan Sandfeld Jensen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review18829 --- Looks good. I started writing such a plugin myself sometime bac

Re: Review Request: add kimgio WebP image format plugin

2012-09-02 Thread Christoph Feck
Hi, I will reply in a single mail. Please do not forget to CC the list, if you don't choose to reply via the RB interface. On Sunday 02 September 2012 15:42:03 Martin Koller wrote: > On Sunday, 2. September 2012 02:07:06 you wrote: > > Additionally, I would like the loader to return a Format_RGB3

Re: Review Request: add kimgio WebP image format plugin

2012-09-01 Thread Christoph Feck
> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote: > > kimgio/webp.cpp, line 49 > > > > > > Needs to check image.isValid() before writing data via scanLine() > > pointers. The allocation may fail because of too la

Re: Review Request: add kimgio WebP image format plugin

2012-09-01 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/ --- (Updated Sept. 1, 2012, 9:23 p.m.) Review request for kdelibs. Changes -

Re: Review Request: add kimgio WebP image format plugin

2012-09-01 Thread Martin Koller
> On Sept. 1, 2012, 1:20 p.m., Christoph Feck wrote: > > kimgio/webp.cpp, line 5 > > > > > > We need to be more verbose here, it has to state the versions, and a > > pointer where to get the license text. Please chec

Re: Review Request: add kimgio WebP image format plugin

2012-09-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/#review18386 --- Nice work, much requested. See issues below. kimgio/webp.cpp

Review Request: add kimgio WebP image format plugin

2012-09-01 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106300/ --- Review request for kdelibs. Description --- This patch adds support f