Re: Review Request: Using KWallet to store Cookies

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4927/#review10132 --- Can you discard this, since it is superceded by http://git.revie

Re: Review Request: Using KWallet to store Cookies

On Wed, 4 May 2011 12:25:07 PM José Millán Soto wrote: > It's a simple way to store the cookies encrypted. I think Ingo's question is about _why_ you want to encrypt cookies. We don't usually encrypt for no reason (it just makes everything slower). We encrypt to protect information from some spec

Re: Review Request: Using KWallet to store Cookies

> On April 27, 2011, 8:49 p.m., Ingo Klöcker wrote: > > No review of your patch. Rather a question about it's usefulness: Why do > > you think cookies should be stored in KWallet? What is the threat model? > > > > The main reason for storing passwords in KWallet is that KWallet remembers > > a

Re: Review Request: Using KWallet to store Cookies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101241/#review2929 --- No review of your patch. Rather a question about it's usefulness

Review Request: Using KWallet to store Cookies

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101241/ --- Review request for kdelibs. Summary --- Currently cookies are stored

Re: Review Request: Using KWallet to store Cookies

On Tue, Apr 19, 2011 at 11:55 AM, todd rme wrote: > On Tue, Apr 19, 2011 at 7:40 AM, Leo Savernik wrote: >> Am Freitag, 21. Januar 2011 schrieb José Millán Soto: >>> Currently cookies are stored in a plain text file. This patch allows >>> KCookieJar to store the cookies securely using KWallet. >>

Re: Review Request: Using KWallet to store Cookies

On Tue, Apr 19, 2011 at 7:40 AM, Leo Savernik wrote: > Am Freitag, 21. Januar 2011 schrieb José Millán Soto: >> Currently cookies are stored in a plain text file. This patch allows >> KCookieJar to store the cookies securely using KWallet. >> >> The main problem I had writing this patch was that w

Re: Review Request: Using KWallet to store Cookies

Am Freitag, 21. Januar 2011 schrieb José Millán Soto: > Currently cookies are stored in a plain text file. This patch allows > KCookieJar to store the cookies securely using KWallet. > > The main problem I had writing this patch was that when a web page is > requested, KIO ask for the cookies to k

Re: Review Request: Using KWallet to store Cookies

Would you be able to create a new request in git.reviewboard.kde.org for this so that it won't fall through the cracks ? Perhaps there is still a chance for this making the KDE 4.7 release. The only reservation I have is the ability to unit test things when cookies are stored in the kwallet. Have y

Re: Review Request: Using KWallet to store Cookies

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4927/ --- (Updated Jan. 21, 2011, 5:37 p.m.) Review request for kdelibs. Changes ---

Re: Review Request: Using KWallet to store Cookies

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4927/#review8357 --- For the record I too share David's concern with nested event loops

Re: Review Request: Using KWallet to store Cookies

> On 2010-11-16 11:21:29, David Faure wrote: > > /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp, line 499 > > > > > > Same here. Why use Asynchronous if you make it sync anyway? > > > > I see y

Re: Review Request: Using KWallet to store Cookies

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4927/#review8753 --- /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.c