Re: Review Request: Shared empty private class for KTimeZoneBackend

2011-06-13 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101593/#review3864 --- Ship it! Looks good. kdecore/date/ktimezone.cpp

Re: Review Request: Shared empty private class for KTimeZoneBackend

2011-06-13 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101593/ --- (Updated June 13, 2011, 9:38 a.m.) Review request for kdelibs, John Layt a

Re: Review Request: Shared empty private class for KTimeZoneBackend

2011-06-13 Thread David Jarvie
> On June 13, 2011, 1:34 a.m., Michael Pyne wrote: > > kdecore/date/ktimezone.cpp, line 622 > > > > > > I received a crash based on this assert when testing with Kontact. I > > take it the refCount is 2 now. ;) > >

Re: Review Request: Shared empty private class for KTimeZoneBackend

2011-06-12 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101593/#review3853 --- kdecore/date/ktimezone.cpp

Review Request: Shared empty private class for KTimeZoneBackend

2011-06-12 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101593/ --- Review request for kdelibs, John Layt and David Jarvie. Summary --- T