Re: Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

2012-04-30 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/#review13186 --- This review has been submitted with commit 0057256b1a0a601346f

Re: Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

2012-04-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/#review13181 --- Ship it! Oh I see, it's a bug in reviewboard. The method name

Re: Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

2012-04-30 Thread Dawit Alemayehu
> On April 30, 2012, 8:41 p.m., David Faure wrote: > > Looks ok, but probably needs rebasing, the code in > > ProtoQueue::removeJob(SimpleJob *job) looks very different here. > > > > (I think checking for job being null is overzealous) Hmm... It applies just fine here on the 4.8 branch and I d

Re: Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

2012-04-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/#review13169 --- Looks ok, but probably needs rebasing, the code in ProtoQueue:

Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

2012-03-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/ --- Review request for kdelibs. Description --- This patch sets the top l