Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-12-21 Thread Dawit Alemayehu
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-25 Thread Dawit Alemayehu
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-25 Thread Albert Astals Cid
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-23 Thread Dawit Alemayehu
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-23 Thread Albert Astals Cid
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-22 Thread Dawit Alemayehu
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-22 Thread David Faure
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-22 Thread Frank Reininghaus
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-22 Thread Albert Astals Cid
> On Nov. 22, 2012, 7:45 p.m., David Faure wrote: > > This probably needs a #ifdef on the kdelibs version number, then, since > > apparently kde-baseapps master only requires kdelibs-4.8... > > > > It says find_package(KDE4 4.8.0 REQUIRED). Not sure why not 4.9 at least, > > but that wouldn't

Re: Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107421/#review22391 --- This probably needs a #ifdef on the kdelibs version number, the

Review Request: Remove usage of KIO::SlaveConfig from Dolphin

2012-11-22 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107421/ --- Review request for KDE Base Apps, David Faure and Frank Reininghaus. Descr