Re: Review Request: Port shutdown dialog to QML

Em Friday 02 March 2012, Laszlo Papp escreveu: > > On Feb. 6, 2012, 9:38 p.m., Alexander Neundorf wrote: > > > Good from my POV (cmake stuff). > > > > Christoph Feck wrote: > > UI-wise looks also fine. Was there anything else we needed to do? If > > not, merge to master. Thanks, you rock!

Re: Review Request: Port shutdown dialog to QML

> On Feb. 6, 2012, 9:38 p.m., Alexander Neundorf wrote: > > Good from my POV (cmake stuff). > > Christoph Feck wrote: > UI-wise looks also fine. Was there anything else we needed to do? If not, > merge to master. Thanks, you rock! Alex, we need this FindKdeclarative.cmake in kdelibs, and n

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10408 --- This review has been submitted with commit 49e65509f9bada70382

Re: Review Request: Port shutdown dialog to QML

> On Feb. 6, 2012, 9:38 p.m., Alexander Neundorf wrote: > > Good from my POV (cmake stuff). UI-wise looks also fine. Was there anything else we needed to do? If not, merge to master. Thanks, you rock! - Christoph --- This is an automat

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10379 --- Ship it! Good from my POV (cmake stuff). - Alexander Neundorf

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Feb. 4, 2012, 2:04 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10274 --- ksmserver/FindKDeclarative.cmake

Re: Review Request: Port shutdown dialog to QML

> On Jan. 30, 2012, 4:44 p.m., Raphael Kubo da Costa wrote: > > ksmserver/FindKDeclarative.cmake, line 14 > > > > > > Where is Copyright.txt? :) > > > > If you move this file to cmake/modules you can share t

Re: Review Request: Port shutdown dialog to QML

> On Jan. 30, 2012, 3:40 p.m., Raphael Kubo da Costa wrote: > > Isn't it better to move FindKDeclarative.cmake to the top-level > > cmake/modules directory with the other find-files? No if the intention is to prevent the file from being installed, which is the case here. > On Jan. 30, 2012,

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 30, 2012, 5:08 p.m.) Review request for KDE Base Apps and KD

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10238 --- ksmserver/FindKDeclarative.cmake

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 30, 2012, 4:35 p.m.) Review request for KDE Base Apps and KD

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10232 --- Isn't it better to move FindKDeclarative.cmake to the top-level

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 30, 2012, 2:28 p.m.) Review request for KDE Base Apps and KD

Re: Review Request: Port shutdown dialog to QML

Em Tuesday 17 January 2012, Alexander Neundorf escreveu: > On Friday 06 January 2012, Alexander Neundorf wrote: > > On Friday 06 January 2012, Lamarque V. Souza wrote: > > > Em Thursday 05 January 2012, Alexander Neundorf escreveu: > > > > On Thursday 05 January 2012, Lamarque V. Souza wrote: > > >

Re: Review Request: Port shutdown dialog to QML

On Friday 06 January 2012, Alexander Neundorf wrote: > On Friday 06 January 2012, Lamarque V. Souza wrote: > > Em Thursday 05 January 2012, Alexander Neundorf escreveu: > > > On Thursday 05 January 2012, Lamarque V. Souza wrote: > > > > Em Wednesday 04 January 2012, Alexander Neundorf escreveu: > >

Re: Review Request: Port shutdown dialog to QML

On Friday 06 January 2012, Lamarque V. Souza wrote: > Em Thursday 05 January 2012, Alexander Neundorf escreveu: > > On Thursday 05 January 2012, Lamarque V. Souza wrote: > > > Em Wednesday 04 January 2012, Alexander Neundorf escreveu: > > > > On Wednesday 04 January 2012, Lamarque Vieira Souza wrot

Re: Review Request: Port shutdown dialog to QML

Em Thursday 05 January 2012, Alexander Neundorf escreveu: > On Thursday 05 January 2012, Lamarque V. Souza wrote: > > Em Wednesday 04 January 2012, Alexander Neundorf escreveu: > > > On Wednesday 04 January 2012, Lamarque Vieira Souza wrote: > > > > > On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid w

Re: Review Request: Port shutdown dialog to QML

On Thursday 05 January 2012, Lamarque V. Souza wrote: > Em Wednesday 04 January 2012, Alexander Neundorf escreveu: > > On Wednesday 04 January 2012, Lamarque Vieira Souza wrote: > > > > On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > > > > ksmserver/CMakeLists.txt, line 57 > > > > >

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 5, 2012, 2:13 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

On Wednesday 04 January 2012 20.54.27 Alexander Neundorf wrote: > It would mean that simply using "kdeclarative" means that cmake > interprets this as name of a library and simply adds -lkdeclarative to the > command > line, without checking whether it actually exists nor in which directory. I ca

Re: Review Request: Port shutdown dialog to QML

Em Wednesday 04 January 2012, Alexander Neundorf escreveu: > On Wednesday 04 January 2012, Lamarque Vieira Souza wrote: > > > On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > > > ksmserver/CMakeLists.txt, line 57 > > > >

Re: Review Request: Port shutdown dialog to QML

On Wednesday 04 January 2012, Lamarque Vieira Souza wrote: > > On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > > ksmserver/CMakeLists.txt, line 57 > > > > > ne57> > > > > > > no variable for kdeclarative? > > >

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 7:19 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > ksmserver/CMakeLists.txt, line 57 > > > > > > no variable for kdeclarative? > > Lamarque Vieira Souza wrote: > There is one in shutdowndlg.cpp, in KSMSh

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > ksmserver/CMakeLists.txt, line 57 > > > > > > no variable for kdeclarative? > > Lamarque Vieira Souza wrote: > There is one in shutdowndlg.cpp, in KSMSh

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 6:41 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: > > Very nice work, one of the things where QML makes sense. > > > > Are there any i18n string regressions? If possible, I would see it in 4.8 > > (maybe not 4.8.0, but backport sometimes later, after it has received > > testing in master),

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 6:08 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 4:58 p.m., Christoph Feck wrote: > > ksmserver/themes/default/main.qml, line 166 > > > > > > Note that pointSize != pixelSize. With a high DPI display, a 10 pt font > > could be 30 pixels large

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some > > consistency there would be nice > > > > You need to extract the i18n messages from the qml files > > > > And having the keyboard not working seems like a huge r

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: > > Very nice work, one of the things where QML makes sense. > > > > Are there any i18n string regressions? If possible, I would see it in 4.8 > > (maybe not 4.8.0, but backport sometimes later, after it has received > > testing in master),

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: > > Very nice work, one of the things where QML makes sense. > > > > Are there any i18n string regressions? If possible, I would see it in 4.8 > > (maybe not 4.8.0, but backport sometimes later, after it has received > > testing in master),

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 5:03 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9537 --- ksmserver/themes/default/main.qml

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 3:57 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: > > Very nice work, one of the things where QML makes sense. > > > > Are there any i18n string regressions? If possible, I would see it in 4.8 > > (maybe not 4.8.0, but backport sometimes later, after it has received > > testing in master),

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some > > consistency there would be nice > > > > You need to extract the i18n messages from the qml files > > > > And having the keyboard not working seems like a huge r

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some > > consistency there would be nice > > > > You need to extract the i18n messages from the qml files > > > > And having the keyboard not working seems like a huge r

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9521 --- Very nice work, one of the things where QML makes sense. Are th

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some > > consistency there would be nice > > > > You need to extract the i18n messages from the qml files > > > > And having the keyboard not working seems like a huge r

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9516 --- Some of your QtQuick imports are 1.0 and some others 1.1, i gues

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 3, 2012, 5:34 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 3, 2012, 5:20 p.m.) Review request for KDE Base Apps and KDE

Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- Review request for KDE Base Apps and KDE Runtime. Description --- Por