Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/#review2943 --- This review has been submitted with commit 3ab6c7f05f113353435e

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/#review2938 --- Ship it! OK, I understand now. Thanks! - David On April 27,

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
> On April 27, 2011, 11:42 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 367 > > > > > > Sorry, I still have a question. > > > > After a username change, setHost is going to be called, right? So i

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/#review2935 --- kioslave/ftp/ftp.cpp

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/ --- (Updated April 27, 2011, 9:27 p.m.) Review request for kdelibs and David F

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
> On April 27, 2011, 7:58 p.m., David Faure wrote: > > kioslave/ftp/ftp.cpp, line 605 > > > > > > Oh, I thought we could remove the boolean altogether. > > > > I don't really understand the way the patch wo

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/#review2926 --- kioslave/ftp/ftp.cpp

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/ --- (Updated April 27, 2011, 7:28 a.m.) Review request for kdelibs and David F

Re: Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-21 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/ --- (Updated April 22, 2011, 4:13 a.m.) Review request for kdelibs. Summary

Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

2011-04-21 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101173/ --- Review request for kdelibs. Summary --- The attached patch addresses