Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/#review10155 --- This review has been submitted with commit 92385ff42503710f7b4

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/#review10152 --- This review has been submitted with commit 349264ee404c8a6b3d4

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-24 Thread Dawit Alemayehu
> On Jan. 25, 2012, 12:07 a.m., David Faure wrote: > > konqueror/src/konqtabs.cpp, line 118 > > > > > > Shouldn't this connect be removed then? > > > > Isn't there a risk that both signals get emitted in so

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/#review10065 --- konqueror/src/konqtabs.cpp

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-22 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/ --- (Updated Jan. 22, 2012, 6:18 p.m.) Review request for KDE Base Apps and Da

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-22 Thread Dawit Alemayehu
> On Jan. 21, 2012, 8:43 p.m., Frank Reininghaus wrote: > > Your patch fixes the bug, but it also causes a regression: If the tab > > contains a split view, the tab title is not highlighted any more. It seems > > that the purpose of the function KonqFrameTabs::tabWhereActive() is to get > > th

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-21 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/#review9993 --- Your patch fixes the bug, but it also causes a regression: If th

Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/ --- Review request for KDE Base Apps and David Faure. Description --- If