Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-10 Thread David Faure
> On May 10, 2012, 8:41 a.m., David Faure wrote: > > Preferred? I'm confused. Aren't the checked keywords the only ones that > > work, and the other ones are disabled? > > > > IMHO this is enabled/disabled, not preferred (which sounds like the other > > ones are working, just harder to reach)

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-10 Thread Dawit Alemayehu
> On May 10, 2012, 8:41 a.m., David Faure wrote: > > Preferred? I'm confused. Aren't the checked keywords the only ones that > > work, and the other ones are disabled? > > > > IMHO this is enabled/disabled, not preferred (which sounds like the other > > ones are working, just harder to reach)

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/#review13653 --- Preferred? I'm confused. Aren't the checked keywords the only o

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/#review13631 --- This review has been submitted with commit 0707b07d3afb14870d5

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-09 Thread Andrea Diamantini
> On May 9, 2012, 9:34 p.m., Andrea Diamantini wrote: > > Ship It! I like it. And code changes seem easy and safe. - Andrea --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/#review1

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-09 Thread Andrea Diamantini
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/#review13627 --- Ship it! Ship It! - Andrea Diamantini On May 9, 2012, 8:35

Review Request: Move the Preferred Web shorcut selection checkbox into its own column

2012-05-09 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/ --- Review request for KDE Runtime. Description --- The following patch m