Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-10 Thread Michael Palimaka
> On July 3, 2012, 12:07 p.m., Aurélien Gâteau wrote: > > Was this actually asked by packagers? I am no expert, but the feedback I > > had from a Debian packager working on CMake projects was that he preferred > > to have all dependencies listed in the top-level CMakeLists.txt. > > > > The rea

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-03 Thread Aurélien Gâteau
> On July 3, 2012, 12:07 p.m., Aurélien Gâteau wrote: > > Was this actually asked by packagers? I am no expert, but the feedback I > > had from a Debian packager working on CMake projects was that he preferred > > to have all dependencies listed in the top-level CMakeLists.txt. > > > > The rea

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-03 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105402/#review15336 --- Was this actually asked by packagers? I am no expert, but the f

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105402/#review15306 --- This review has been submitted with commit e6d030f33a366b1d009

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-02 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105402/#review15304 --- This review has been submitted with commit e2061f512ce1f422290

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-02 Thread George Kiagiadakis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105402/#review15303 --- Ship it! Looks harmless, go ahead - George Kiagiadakis On J

Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-01 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105402/ --- Review request for KDE Runtime and George Kiagiadakis. Description ---