Re: Review Request: Minor krazy2 warning fixes

2012-05-01 Thread Dawit Alemayehu
> On May 1, 2012, 9:55 a.m., Konstantinos Smanis wrote: > > kioslave/http/kcookiejar/kcookiejar_include.h, line 6 > > > > > > Does it compile without the include? Yes that compiles fine. Even if certain includes are

Re: Review Request: Minor krazy2 warning fixes

2012-04-30 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/ --- (Updated April 30, 2012, 11:50 p.m.) Review request for kdelibs. Changes

Re: Review Request: Minor krazy2 warning fixes

2012-04-30 Thread Dawit Alemayehu
> On April 29, 2012, 7:56 p.m., Konstantinos Smanis wrote: > > kio/bookmarks/kbookmarkdombuilder.cc, line 41 > > > > > > You change the signature here (second argument: bool->QString) > > David Faure wrote: > Wo

Re: Review Request: Minor krazy2 warning fixes

2012-04-30 Thread David Faure
> On April 29, 2012, 7:56 p.m., Konstantinos Smanis wrote: > > kio/bookmarks/kbookmarkdombuilder.cc, line 41 > > > > > > You change the signature here (second argument: bool->QString) Wow, well spotted. Dawit, don't

Re: Review Request: Minor krazy2 warning fixes

2012-04-30 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/#review13105 --- kio/bookmarks/kbookmarkdombuilder.cc

Re: Review Request: Minor krazy2 warning fixes

2012-04-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/ --- (Updated April 29, 2012, 8:22 p.m.) Review request for kdelibs. Changes

Re: Review Request: Minor krazy2 warning fixes

2012-04-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/#review13102 --- Looks good, except for some #include changes. - David Faure

Re: Review Request: Minor krazy2 warning fixes

2012-04-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/#review13101 --- kio/bookmarks/konqbookmarkmenu.cc

Review Request: Minor krazy2 warning fixes

2012-04-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/ --- Review request for kdelibs. Description --- The following patch fixes