Re: Review Request: Make the writeConfig() method a public slot

2012-02-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103829/#review10273 --- This review has been submitted with commit 827d7cb30d61fca61be

Re: Review Request: Make the writeConfig() method a public slot

2012-01-30 Thread Frank Reininghaus
> On Jan. 30, 2012, 10:21 p.m., Frank Reininghaus wrote: > > AFAIK, changing the order of virtual member functions might break binary > > compatibility: > > > > http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ Sorry about that, I missed the "Branch: frameworks". - Frank

Re: Review Request: Make the writeConfig() method a public slot

2012-01-30 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103829/#review10252 --- AFAIK, changing the order of virtual member functions might bre

Re: Review Request: Make the writeConfig() method a public slot

2012-01-30 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103829/#review10251 --- Ship it! That looks pretty straightforward and makes sense. -

Review Request: Make the writeConfig() method a public slot

2012-01-30 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103829/ --- Review request for kdelibs and David Faure. Description --- According