Re: Review Request: Make mouse cursor size configurable

2012-03-02 Thread Lukas Sommer
> On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote: > > kcontrol/input/xcursor/cursortheme.cpp, line 119 > > > > > > Scaling a pixmap is more expensive than scaling an image. Internally it > > involves converting

Re: Review Request: Make mouse cursor size configurable

2011-11-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review8071 --- This review has been submitted with commit 617b08f5f6652bb9d918

Re: Review Request: Make mouse cursor size configurable

2011-11-09 Thread Fredrik Höglund
> On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote: > > kcontrol/input/xcursor/cursortheme.cpp, line 119 > > > > > > Scaling a pixmap is more expensive than scaling an image. Internally it > > involves converting

Re: Review Request: Make mouse cursor size configurable

2011-11-09 Thread Lukas Sommer
> On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote: > > Sorry for not finding the time to follow up on this until now. > > > > The new design is not quite what I had in mind, but given that the freeze > > is tomorrow I'm fine with including it in 4.8. > > > > I have given the code a quick loo

Re: Review Request: Make mouse cursor size configurable

2011-11-09 Thread Lukas Sommer
> On Nov. 9, 2011, 6:48 a.m., Fredrik Höglund wrote: > > kcontrol/input/xcursor/cursortheme.cpp, line 119 > > > > > > Scaling a pixmap is more expensive than scaling an image. Internally it > > involves converting

Re: Review Request: Make mouse cursor size configurable

2011-11-09 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review8036 --- Ship it! Sorry for not finding the time to follow up on this un

Re: Review Request: Make mouse cursor size configurable

2011-11-07 Thread Christoph Feck
> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider,

Re: Review Request: Make mouse cursor size configurable

2011-10-08 Thread Lukas Sommer
> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider,

Re: Review Request: Make mouse cursor size configurable

2011-10-05 Thread Christoph Feck
> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider,

Re: Review Request: Make mouse cursor size configurable

2011-10-05 Thread Lukas Sommer
> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider,

Re: Review Request: Make mouse cursor size configurable

2011-09-23 Thread Lukas Sommer
> On Sept. 21, 2011, 1:05 p.m., Christoph Feck wrote: > > What I dislike is the position of the size combo box. Either it should be > > below the list, or, when above the list, share the space with the preview. > > > > Regarding the "use DPI depended size", what we could do if we use a slider,

Re: Review Request: Make mouse cursor size configurable

2011-09-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review6697 --- What I dislike is the position of the size combo box. Either it

Re: Review Request: Make mouse cursor size configurable

2011-09-02 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- (Updated Sept. 2, 2011, 4:40 p.m.) Review request for KDE Base Apps, KDE R

Re: Review Request: Make mouse cursor size configurable

2011-09-02 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- (Updated Sept. 2, 2011, 4:39 p.m.) Review request for KDE Base Apps, KDE R

Re: Review Request: Make mouse cursor size configurable

2011-09-02 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- (Updated Sept. 2, 2011, 4:38 p.m.) Review request for KDE Base Apps, KDE R

Re: Review Request: Make mouse cursor size configurable

2011-09-02 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- (Updated Sept. 2, 2011, 4:37 p.m.) Review request for KDE Base Apps, KDE R

Re: Review Request: Make mouse cursor size configurable

2011-07-21 Thread Lukas Sommer
> On July 20, 2011, 2:46 p.m., Fredrik Höglund wrote: > > Lucas, first of all I want to say thank you for working on this. > > > > In good UI design it is important to think about the problem the user > > wants to solve from the user's point of view, and not in terms of how > > the underlying im

Re: Review Request: Make mouse cursor size configurable

2011-07-21 Thread Lukas Sommer
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-20 Thread Chusslove Illich
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-20 Thread Fredrik Höglund
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review4898 --- Lucas, first of all I want to say thank you for working on this.

Re: Review Request: Make mouse cursor size configurable

2011-07-20 Thread Christoph Feck
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/themepage.ui, line 78 > > > > > > sizePolicyComboBox, there is no Police here ;) > > Lukas Sommer wrote: > How should I name this?

Re: Review Request: Make mouse cursor size configurable

2011-07-20 Thread Lukas Sommer
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/themepage.ui, line 78 > > > > > > sizePolicyComboBox, there is no Police here ;) How should I name this? - Lukas --

Re: Review Request: Make mouse cursor size configurable

2011-07-18 Thread Lukas Sommer
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-18 Thread Chusslove Illich
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-18 Thread Lukas Sommer
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Chusslove Illich
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Lukas Sommer
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Chusslove Illich
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-17 Thread Lukas Sommer
> On July 12, 2011, 8:56 a.m., Christoph Feck wrote: > > kcontrol/input/xcursor/xcursortheme.cpp, line 73 > > > > > > Do you mean the sizes are always > 0, or do you mean the number of > > entries in the list is > 0

Re: Review Request: Make mouse cursor size configurable

2011-07-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/#review4633 --- kcontrol/input/xcursor/cursortheme.h

Review Request: Make mouse cursor size configurable

2011-06-20 Thread Lukas Sommer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101701/ --- Review request for KDE Base Apps, KDE Runtime, kdelibs, and Christoph Feck.