Re: Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105920/#review17175 --- This review has been submitted with commit e9b1714f408f708237c

Re: Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-09 Thread David Faure
> On Aug. 8, 2012, 1:08 p.m., Aurélien Gâteau wrote: > > The reason it was not applied is probably because I forgot to submit it :) > > Thanks for taking care of doing it. > > > > If I am not mistaken the reason KModifierKeyInfoProvider inherits from > > QWidget is historical: it used to be ne

Re: Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105920/#review17144 --- Ship it! - David Faure On Aug. 7, 2012, 9:21 p.m., Frank Rei

Re: Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-08 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105920/#review17101 --- The reason it was not applied is probably because I forgot to s

Review Request: Make KModifierKeyInfoProvider inherit QObject, rather than QWidget

2012-08-07 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105920/ --- Review request for kdelibs, Michael Leupold and Aurélien Gâteau. Descripti