Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread Aurélien Gâteau
> On Oct. 2, 2012, 10:55 a.m., David Faure wrote: > > kfile/kfilewidget.cpp, line 1875 > > > > > > OK, I was about to react against the move to a member variable > > configGroup (which basically means "accept() wi

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/ --- (Updated Oct. 2, 2012, 10:55 a.m.) Review request for kdelibs and Andreas

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/#review19741 --- kfile/kfilewidget.cpp

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/ --- (Updated Oct. 2, 2012, 10:12 a.m.) Review request for kdelibs. Changes -

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread Aurélien Gâteau
> On Sept. 30, 2012, 8:26 a.m., David Faure wrote: > > Looks good to me (feel free to commit if nobody else has comments). > > > > But then, what if someone is annoyed by icon views, and wants a details > > view everywhere? [switch this sentence around if the default is details > > view] > > H

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread David Faure
> On Sept. 30, 2012, 8:26 a.m., David Faure wrote: > > Looks good to me (feel free to commit if nobody else has comments). > > > > But then, what if someone is annoyed by icon views, and wants a details > > view everywhere? [switch this sentence around if the default is details > > view] > > H

Re: Review Request: Make KFileDialog remember settings

2012-10-02 Thread Aurélien Gâteau
> On Sept. 30, 2012, 8:26 a.m., David Faure wrote: > > Looks good to me (feel free to commit if nobody else has comments). > > > > But then, what if someone is annoyed by icon views, and wants a details > > view everywhere? [switch this sentence around if the default is details > > view] > > H

Re: Review Request: Make KFileDialog remember settings

2012-09-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/#review19620 --- Looks good to me (feel free to commit if nobody else has commen

Review Request: Make KFileDialog remember settings

2012-09-26 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106581/ --- Review request for kdelibs. Description --- This patch makes KFileDia