Il 01 aprile 2012 14:35, Stephen Kelly ha scritto:
> Dario Freddi wrote:
>> gitk indeed has a screwy visualization in there.
>
> You conclusion that the tool is screwy is interesting for a few reasons.
> Maybe some day you'll reconsider it.
Wait - I was considering just this specific case. I rare
Dario Freddi wrote:
> gitk indeed has a screwy visualization in there.
You conclusion that the tool is screwy is interesting for a few reasons.
Maybe some day you'll reconsider it.
>> More importantly though, you seem to have broken the frameworks branch.
>
> True, sorry about that. This is fix
Il 31 marzo 2012 21:03, Stephen Kelly ha scritto:
>
> Now I'm confused.
>
>>> Stephen Kelly wrote:
>>> It was rebased onto some relatively recent commit, but not the tip of
>>> the branch.
>
> You disagreed with what I said:
>
>> - Given that the branch was rebased on top of the last fram
Now I'm confused.
>> Stephen Kelly wrote:
>> It was rebased onto some relatively recent commit, but not the tip of
>> the branch.
You disagreed with what I said:
> - Given that the branch was rebased on top of the last frameworks' commit
> (as you can see from the log),
... actually
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
>
> Stephen Kelly wrote:
> Thanks for making this happ
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
>
> Stephen Kelly wrote:
> Thanks for making this happ
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
>
> Stephen Kelly wrote:
> Thanks for making this happ
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
>
> Stephen Kelly wrote:
> Thanks for making this happ
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
>
> Stephen Kelly wrote:
> Thanks for making this happ
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104337/#review12059
---
This review has been submitted with commit
1f6e4685b66090c3e99
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
>
> Stephen Kelly wrote:
> Thanks for making this happ
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
>
> Stephen Kelly wrote:
> Thanks for making this happ
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
>
> Stephen Kelly wrote:
> Thanks for making this happ
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote:
> > April is upon us. If no objections arise in the time being, these changes
> > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to
> > tier2/ for prime time.
Thanks for making this happen! :)
Instead of merging, ple
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104337/#review12013
---
April is upon us. If no objections arise in the time being, the
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote:
> > Nice, thanks and sorry for the noise, and thanks for making the branch.
>
> Dario Freddi wrote:
> Np, hope you'll be able to have a quick look at it as well, it would be
> great :)
>
> Stephen Kelly wrote:
> Mostly it looks fine
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote:
> > Nice, thanks and sorry for the noise, and thanks for making the branch.
>
> Dario Freddi wrote:
> Np, hope you'll be able to have a quick look at it as well, it would be
> great :)
>
> Stephen Kelly wrote:
> Mostly it looks fine
> On March 21, 2012, 8:54 p.m., Alexander Neundorf wrote:
> > I did not yet have time to look through the git branch...
> >
> > So, kauth, we have a bunch of cmake macros related to this in
> > kdelibs/cmake/KDE4Macros.cmake, right ?
> > What about them ?
>
> Stephen Kelly wrote:
> They ar
> On March 21, 2012, 8:54 p.m., Alexander Neundorf wrote:
> > I did not yet have time to look through the git branch...
> >
> > So, kauth, we have a bunch of cmake macros related to this in
> > kdelibs/cmake/KDE4Macros.cmake, right ?
> > What about them ?
They are already in ${CMAKE_SOURCE_DIR
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104337/#review11717
---
I did not yet have time to look through the git branch...
So,
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote:
> > Nice, thanks and sorry for the noise, and thanks for making the branch.
>
> Dario Freddi wrote:
> Np, hope you'll be able to have a quick look at it as well, it would be
> great :)
>
> Stephen Kelly wrote:
> Mostly it looks fine
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote:
> > Nice, thanks and sorry for the noise, and thanks for making the branch.
>
> Dario Freddi wrote:
> Np, hope you'll be able to have a quick look at it as well, it would be
> great :)
>
> Stephen Kelly wrote:
> Mostly it looks fine
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote:
> > Nice, thanks and sorry for the noise, and thanks for making the branch.
>
> Dario Freddi wrote:
> Np, hope you'll be able to have a quick look at it as well, it would be
> great :)
>
> Stephen Kelly wrote:
> Mostly it looks fine
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote:
> > Nice, thanks and sorry for the noise, and thanks for making the branch.
>
> Dario Freddi wrote:
> Np, hope you'll be able to have a quick look at it as well, it would be
> great :)
Mostly it looks fine.
The enums are not named con
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104337/#review11598
---
In kauth/autotests/HelperTest.cpp The comment on line 57-68 sho
> On March 19, 2012, 12:17 a.m., Henry Miller wrote:
> > In kauth/autotests/HelperTest.cpp The comment on line 57-68 should be
> > reworded. In general when someone is told not to touch some lines they
> > won't. You should be clear on why the code is that way. However saying
> > "you don't w
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote:
> > Nice, thanks and sorry for the noise, and thanks for making the branch.
Np, hope you'll be able to have a quick look at it as well, it would be great :)
- Dario
---
This is an au
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104337/#review11596
---
Nice, thanks and sorry for the noise, and thanks for making the
> On March 18, 2012, 10:55 p.m., Stephen Kelly wrote:
> > Given that it does so many things, I wonder if it should be split into
> > multiple patches. (I didn't fetch the branch - maybe you already have it in
> > multiple patches) For examples, renaming the enums in one commit, making
> > Acti
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104337/#review11594
---
Given that it does so many things, I wonder if it should be spl
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104337/
---
Review request for kdelibs, Kevin Ottens, David Faure, and Alexander Neundor
31 matches
Mail list logo
