Re: Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-30 Thread Dan Vrátil
> On Nov. 29, 2012, 10:27 p.m., Mark Gaiser wrote: > > Ehm, this just seems odd to me. Because kdelibs is frozen you add a > > completely new class and public even. Thus you already change the kdelibs > > api which should not be allowed. > > > > Second argument, if this udisks2 is so important

Re: Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-29 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107513/#review22795 --- Ehm, this just seems odd to me. Because kdelibs is frozen you a

Re: Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-29 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107513/ --- (Updated Nov. 29, 2012, 2:55 p.m.) Review request for kdelibs, Lukáš Tinkl

Review Request: Load Solid devices in KFilePlacesModel asynchronously

2012-11-29 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107513/ --- Review request for kdelibs and David Faure. Description --- With KDE