Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-27 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review10148 --- This review has been submitted with commit cfc52e240ae5a15f049

Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review9866 --- This review has been submitted with commit 63c7ae800b22d0d9d6d5

Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review9818 --- Ship it! Yep we want to quote only paths from the file dialog,

Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-01 Thread Ingomar Wesp
> On Jan. 1, 2012, 11:08 p.m., Dawit Alemayehu wrote: > > Why the need for a new slot that connects to urlChanged ? Would simply > > quoting the user selected text in KOpenWithDialog::slotSelected not suffice > > ? AFAICS, KOpenWithDialog::slotSelected is used for setting the contents of the

Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review9417 --- Why the need for a new slot that connects to urlChanged ? Would

Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-01 Thread Ingomar Wesp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/ --- Review request for kdelibs. Description --- KOpenWithDialog expects t