Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20825 --- This review has been submitted with commit d5a0d33a249c52fde68

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Dominik Haumann
> On Oct. 24, 2012, 7:38 p.m., Christoph Feck wrote: > > Are you sure it fixes bug 165355 ? That bug tracks the issue about > > KUniqueApplication (Konsole, etc.) not passing the mentioned arguments to > > the spawned process. > > Christoph Feck wrote: > To clarify: I don't object to have

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/ --- (Updated Oct. 24, 2012, 9:27 p.m.) Review request for kdelibs. Changes -

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Christoph Feck
> On Oct. 24, 2012, 7:38 p.m., Christoph Feck wrote: > > Are you sure it fixes bug 165355 ? That bug tracks the issue about > > KUniqueApplication (Konsole, etc.) not passing the mentioned arguments to > > the spawned process. To clarify: I don't object to have this committed, but unless you c

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20817 --- Are you sure it fixes bug 165355 ? That bug tracks the issue ab

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20816 --- Ship it! With v2, the patch is simlpy a logic inversion to now

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Dominik Haumann
> On Oct. 24, 2012, 5:48 p.m., Thomas Lübking wrote: > > kdeui/widgets/kmainwindow.cpp, line 456 > > > > > > why 0? > > if the value is omitted that likely means "dont care, place regularily" > > - doesn't? Tr

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/ --- (Updated Oct. 24, 2012, 5:56 p.m.) Review request for kdelibs. Changes -

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20809 --- kdeui/widgets/kmainwindow.cpp

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Dominik Haumann
> On Oct. 24, 2012, 4:26 p.m., Milian Wolff wrote: > > works for me :) Any other comments? And into what branch am I supposed to commit? KDE/4.9 and master? - Dominik --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/#review20799 --- Ship it! works for me :) - Milian Wolff On Oct. 24, 2012, 3

Review Request: KMainWindow: fix position support in --geometry option

2012-10-24 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107023/ --- Review request for kdelibs. Description --- KDE applications support