Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-06-01 Thread Rolf Eike Beer
> On April 29, 2012, 6:26 p.m., Maks Orlovich wrote: > > kjs/object.cpp, line 433 > > > > > > more * inconsistency > > Bernd Buschinski wrote: > I don't get the problem here, could you please explain? GetterSe

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-06-01 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated June 1, 2012, 12:34 p.m.) Review request for kdelibs. Changes -

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-05-31 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated May 31, 2012, 8:46 p.m.) Review request for kdelibs. Changes --

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-05-02 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated May 2, 2012, 8:23 p.m.) Review request for kdelibs. Changes ---

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-30 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated April 30, 2012, 7:11 p.m.) Review request for kdelibs. Changes

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-30 Thread Bernd Buschinski
> On April 29, 2012, 6:26 p.m., Maks Orlovich wrote: > > kjs/object.cpp, line 433 > > > > > > more * inconsistency I don't get the problem here, could you please explain? > On April 29, 2012, 6:26 p.m., Maks Orlo

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-30 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/#review13085 --- Still need more big picture stuff... kjs/object.h

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-20 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated April 20, 2012, 11:55 a.m.) Review request for kdelibs. Changes

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-12 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated April 12, 2012, 11:01 p.m.) Review request for kdelibs. Descrip

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-12 Thread Bernd Buschinski
> On April 10, 2012, 2:54 a.m., Maks Orlovich wrote: > > kjs/CMakeLists.txt, line 193 > > > > > > where is this file? > > good question, sorry, I will include it in the next update > On April 10, 2012, 2:54 a.m.,

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-09 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/#review12282 --- I think I need a bit of higher-level info from here; plus I gue

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-09 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated April 9, 2012, 8:23 p.m.) Review request for kdelibs. Changes -

Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-04-08 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- Review request for kdelibs. Description --- KJS: Implement Object.Get