Re: Review Request: KImageCache optimization

2012-02-27 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10925 --- Overall I like the idea of taking a more direct role in KImageC

Re: Review Request: KImageCache optimization

2012-02-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 26, 2012, 8:08 p.m.) Review request for kdelibs, David Faure

Re: Review Request: KImageCache optimization

2012-02-27 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 26, 2012, 6:46 p.m.) Review request for kdelibs, David Faure

Re: Review Request: KImageCache optimization

2012-02-26 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 25, 2012, 10:08 p.m.) Review request for kdelibs, David Faur

Re: Review Request: KImageCache optimization

2012-02-26 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 25, 2012, 8:45 p.m.) Review request for kdelibs, David Faure

Re: Review Request: KImageCache optimization

2012-02-25 Thread Ingo Klöcker
> On Feb. 24, 2012, 1:16 a.m., Michael Pyne wrote: > > kdecore/util/kshareddatacache.cpp, line 1491 > > > > > > The cache is unlocked here but temp is still pointing into its > > internals (as mentioned above)...

Re: Review Request: KImageCache optimization

2012-02-23 Thread Michael Pyne
> On Feb. 24, 2012, 1:16 a.m., Michael Pyne wrote: > > kdecore/util/kshareddatacache.cpp, line 1491 > > > > > > The cache is unlocked here but temp is still pointing into its > > internals (as mentioned above)...

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 24, 2012, 1:16 a.m., Michael Pyne wrote: > > kdecore/util/kshareddatacache.cpp, line 1491 > > > > > > The cache is unlocked here but temp is still pointing into its > > internals (as mentioned above)...

Re: Review Request: KImageCache optimization

2012-02-23 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10858 --- The big issue is a race condition between finding an entry and

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 8:56 p.m., Christoph Feck wrote: > > kdeui/util/kimagecache.cpp, line 106 > > > > > > This fails to correctly handle palettized images. > > > > If we do not want to preserve image texts,

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 23, 2012, 7:23 p.m.) Review request for kdelibs, David Faure

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 23, 2012, 7:21 p.m.) Review request for kdelibs, David Faure

Re: Review Request: KImageCache optimization

2012-02-23 Thread Christoph Feck
> On Feb. 23, 2012, 8:56 p.m., Christoph Feck wrote: > > kdeui/util/kimagecache.cpp, line 106 > > > > > > This fails to correctly handle palettized images. > > > > If we do not want to preserve image texts,

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 8:56 p.m., Christoph Feck wrote: > > kdeui/util/kimagecache.cpp, line 106 > > > > > > This fails to correctly handle palettized images. > > > > If we do not want to preserve image texts,

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 7:57 p.m., Aaron J. Seigo wrote: > > kdecore/util/kshareddatacache.cpp, lines 1488-1496 > > > > > > looking at it again, it appears there is room for one more small > > optimization when destin

Re: Review Request: KImageCache optimization

2012-02-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10851 --- kdeui/util/kimagecache.cpp

Re: Review Request: KImageCache optimization

2012-02-23 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10848 --- kdecore/util/kshareddatacache.cpp

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 6:52 p.m., Aaron J. Seigo wrote: > > kdecore/util/kshareddatacache.cpp, line 1491 > > > > > > this needs a check on destination being not-null. e.g. if (destination > > && !temp.isNull()) above

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 6:33 p.m., Milian Wolff wrote: > > given that you have unit tests at hand, why not write a benchmark to get > > proper before/after numbers that show the impact of this patch? Right.. That's not exactly easy to "just" do since i would have to read a dir with images, insert

Re: Review Request: KImageCache optimization

2012-02-23 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10843 --- kdecore/util/kshareddatacache.cpp

Re: Review Request: KImageCache optimization

2012-02-23 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10842 --- given that you have unit tests at hand, why not write a benchma

Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- Review request for kdelibs, David Faure and Michael Pyne. Description