Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/#review18657 --- This review has been submitted with commit bfddfa873326eb5577d

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-07 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/#review18656 --- This review has been submitted with commit acef4b1c287a315b425

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/#review18644 --- Ship it! dolphin/src/views/dolphinview.h

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/ --- (Updated Sept. 6, 2012, 6:52 p.m.) Review request for Dolphin and KDE Base

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/#review18632 --- dolphin/src/views/dolphinview.h

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-06 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/ --- (Updated Sept. 6, 2012, 4:16 p.m.) Review request for Dolphin and KDE Base

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-06 Thread Frank Reininghaus
> On Sept. 6, 2012, 12:47 p.m., David Faure wrote: > > dolphin/src/dolphinpart.cpp, line 718 > > > > > > IMHO this is worse than a DolphinView::fileItemModel() method, because > > it will break at runtime rather th

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-06 Thread David Faure
> On Sept. 6, 2012, 12:47 p.m., David Faure wrote: > > dolphin/src/dolphinpart.cpp, line 718 > > > > > > IMHO this is worse than a DolphinView::fileItemModel() method, because > > it will break at runtime rather th

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-06 Thread Dawit Alemayehu
> On Sept. 6, 2012, 12:47 p.m., David Faure wrote: > > dolphin/src/dolphinpart.cpp, line 718 > > > > > > IMHO this is worse than a DolphinView::fileItemModel() method, because > > it will break at runtime rather th

Re: Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/#review18625 --- dolphin/src/dolphinpart.cpp

Review Request: Implementation of KPart listing notification extension for Dolphin

2012-09-05 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106333/ --- Review request for Dolphin and KDE Base Apps. Description --- The fol