Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-24 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review19397 --- Unfortunately, there were really some problems due to this fix

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18603 --- This review has been submitted with commit f64a82bd69bcc0f35c9

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18602 --- This review has been submitted with commit 20b0cb68bf5cc1099fd

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-04 Thread Todd Jennings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/ --- (Updated Sept. 3, 2012, 11:29 p.m.) Review request for Dolphin and KDE Bas

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-03 Thread Todd Jennings
> On Sept. 3, 2012, 11:46 a.m., Frank Reininghaus wrote: > > Thanks, looks good from my point of view! I can't test it at the moment, > > but you can commit this the the 4.9 branch. There are a couple of weeks to > > go before 4.9.2 is tagged anyway, and I (and hopefully, more users of the > >

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-03 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18454 --- Ship it! Thanks, looks good from my point of view! I can't tes

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-02 Thread Todd Jennings
> On Sept. 1, 2012, 4:25 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/private/knepomukrolesprovider.cpp, line 112 > > > > > > Hm, at first sight this looks like the loop does essentially nothing - > >

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-02 Thread Todd Jennings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/ --- (Updated Sept. 2, 2012, 10:41 a.m.) Review request for Dolphin and KDE Bas

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-02 Thread Thomas Lübking
> On Sept. 1, 2012, 4:25 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/private/knepomukrolesprovider.cpp, line 112 > > > > > > Hm, at first sight this looks like the loop does essentially nothing - > >

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-01 Thread Todd Jennings
> On Sept. 1, 2012, 4:25 p.m., Frank Reininghaus wrote: > > dolphin/src/kitemviews/kstandarditemlistwidget.cpp, line 990 > > > > > > I would write ... - (additionalRolesCount - emptyRolesCount) here. That > > makes

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-01 Thread Todd Jennings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/ --- (Updated Sept. 1, 2012, 12:17 p.m.) Review request for Dolphin and KDE Bas

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-01 Thread Todd Jennings
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/ --- (Updated Sept. 1, 2012, 12:17 p.m.) Review request for Dolphin and KDE Bas

Re: Review Request: Hide empty additional information lines in icons view mode

2012-09-01 Thread Frank Reininghaus
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106304/#review18407 --- Thanks for the patch, looks good! I have two small comments on