Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review18070 --- This review has been submitted with commit a2ae8003352442efdb5

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review18063 --- This review has been submitted with commit 55c0f6baf97a07d1ee0

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review18006 --- Ship it! Looks good, assuming you tested that it doesn't reint

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-25 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/ --- (Updated Aug. 25, 2012, 7:41 p.m.) Review request for KDE Base Apps and Da

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review17978 --- This is going into the right direction. If you move your new co

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/ --- (Updated Aug. 20, 2012, 8:02 p.m.) Review request for KDE Base Apps and Da

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-20 Thread Dawit Alemayehu
> On Aug. 20, 2012, 8:51 a.m., David Faure wrote: > > Thanks for looking into this. > > > > To be honest, I don't like the timer. It penalizes fast users, and it feels > > like a workaround. Surely at some point konqueror knows whether it's going > > to open a url in the tab or not. That's the

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-20 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review17743 --- Thanks for looking into this. To be honest, I don't like the t

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-19 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/ --- (Updated Aug. 20, 2012, 2:22 a.m.) Review request for KDE Base Apps and Da

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-18 Thread Dawit Alemayehu
> On Aug. 17, 2012, 8:29 p.m., David Faure wrote: > > Not a strong objection, but KonqViewManager::doSetActivePart is supposed to > > do this already, so I'm surprised it doesn't work? > > > > If that method isn't called in your case, then OK. Well I finally figured out why this was happening!

Re: Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/#review17622 --- Not a strong objection, but KonqViewManager::doSetActivePart is

Review Request: Focus goes to location bar when opening link in new tab in foreground

2012-08-11 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105984/ --- Review request for KDE Base Apps and David Faure. Description --- The