Re: Review Request: Fix possible memory and D-Bus connection leak in KStatusNotifierItem

2011-06-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101527/#review4044 --- This review has been submitted with commit d6cc53cd80e326bfea93

Re: Review Request: Fix possible memory and D-Bus connection leak in KStatusNotifierItem

2011-06-06 Thread Dawit Alemayehu
> On June 6, 2011, 8:38 p.m., Aaron J. Seigo wrote: > > i doubt this fix is correct. what looks more like is > > KStatusNotifierItemDBus::~KStatusNotifierItemDBus(). right now this is the > > implementation: > > > > m_dbus.unregisterService(m_service); > > > > and perhaps it should include: >

Re: Review Request: Fix possible memory and D-Bus connection leak in KStatusNotifierItem

2011-06-06 Thread Shaun Reich
> On June 6, 2011, 8:38 p.m., Aaron J. Seigo wrote: > > i doubt this fix is correct. what looks more like is > > KStatusNotifierItemDBus::~KStatusNotifierItemDBus(). right now this is the > > implementation: > > > > m_dbus.unregisterService(m_service); > > > > and perhaps it should include: >

Re: Review Request: Fix possible memory and D-Bus connection leak in KStatusNotifierItem

2011-06-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101527/#review3726 --- i doubt this fix is correct. what looks more like is KStatusNot

Review Request: Fix possible memory and D-Bus connection leak in KStatusNotifierItem

2011-06-06 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101527/ --- Review request for kdelibs, Plasma and Marco Martin. Summary --- Acco