---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102262/#review5682
---
This review has been submitted with commit
3cc10496aa6eb4aae27b
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102262/#review5681
---
This review has been submitted with commit
ddcf5c0fd58bbe4e8572
> On Aug. 11, 2011, 9:13 a.m., David Faure wrote:
> > Ah, I see. Indeed after reading QAction::iconText() it's all clear ;)
> >
> > But yeah this is quite obviously a bug in qaction (qt_strippedText), which
> > should remove "..." only at the end.
It's my first patch in kdelibs, where should i
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102262/#review5621
---
Ship it!
Ah, I see. Indeed after reading QAction::iconText() it
> On Aug. 9, 2011, 10:45 p.m., David Faure wrote:
> > Since you're setting iconText, this is about actions into a toolbar, not
> > into a menu, right?
> >
> > So Qt strips "..." from toolbar button texts? What's the logic there? I'm
> > just curious, the patch looks ok, from your description.
> On Aug. 9, 2011, 10:45 p.m., David Faure wrote:
> > Since you're setting iconText, this is about actions into a toolbar, not
> > into a menu, right?
> >
> > So Qt strips "..." from toolbar button texts? What's the logic there? I'm
> > just curious, the patch looks ok, from your description.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102262/#review5554
---
Since you're setting iconText, this is about actions into a tool
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102262/
---
Review request for kdelibs.
Summary
---
When a bookmark name, is too
