Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/#review7 --- This review has been submitted with commit d5c3c9822a38574162e

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-16 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/#review22071 --- Ship it! Looks good, thanks! - Aurélien Gâteau On Nov. 16,

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/ --- (Updated Nov. 16, 2012, 2:11 a.m.) Review request for kdelibs and Aurélien

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread David Edmundson
> On Nov. 15, 2012, 9:11 a.m., Aurélien Gâteau wrote: > > Good catch, things looks more aligned now. > > > > I am a bit worried about the 2px value being specific to Oxygen widget > > style though. How does it behave with other styles? Maybe you can extract > > this value using QStyle::pixelMe

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/#review22024 --- Good catch, things looks more aligned now. I am a bit worried

Re: Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-15 Thread Dominik Haumann
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/#review22023 --- Interestingly, some comments on http://kate-editor.org/2012/11

Review Request: Fix margin on KMessageWidget to match that used by a styled QFrame.

2012-11-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107332/ --- Review request for kdelibs and Aurélien Gâteau. Description --- Fix m