Re: Review Request: Fix icon generation and installation on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23806 --- This review has been submitted with commit 0695c3fc8eb9e288ede

Re: Review Request: Fix icon generation and installation on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23805 --- This review has been submitted with commit 52ee764212613012f1f

Re: Review Request: Fix icon generation and installation on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23795 --- Ship it! If it does not break on other systems, like Linux, Wi

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. that doesn't sav

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 16, 2012, 1:47 p.m., Laszlo Papp wrote: > > cmake/modules/KDE4Macros.cmake, line 1293 > > > > > > Wouldn't it be nicer to write a loop for this with the icon resolutions? > > Yue Liu wrote: > osx ico

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 20, 2012, 6:58 p.m., Laszlo Papp wrote: > > Great, thank you for your care! One suggestion to this, and I think then it > > is fine from that point of view: you could write a foreach on top of the > > "copy_icons" macro, and avoid the same function name in each line. > > Yue Liu wrot

Re: Review Request: Fix icon generation and installation on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23767 --- Great, thank you for your care! One suggestion to this, and I t

Re: Review Request: Fix icon generation and installation on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/ --- (Updated Dec. 20, 2012, 6:10 p.m.) Review request for kdelibs. Changes -

Re: Review Request: Fix icon generation and installation on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23730 --- Thanks for this - I was just trying to figure out why the konso

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 16, 2012, 1:47 p.m., Laszlo Papp wrote: > > cmake/modules/KDE4Macros.cmake, line 1293 > > > > > > Wouldn't it be nicer to write a loop for this with the icon resolutions? > > Yue Liu wrote: > osx ico

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 16, 2012, 1:47 p.m., Laszlo Papp wrote: > > cmake/modules/KDE4Macros.cmake, line 1293 > > > > > > Wouldn't it be nicer to write a loop for this with the icon resolutions? osx icon only uses some specific

Re: Review Request: Fix icon generation and installation on OS X

> On Dec. 16, 2012, 1:47 p.m., Laszlo Papp wrote: > > cmake/modules/KDE4Macros.cmake, line 1293 > > > > > > Wouldn't it be nicer to write a loop for this with the icon resolutions? > > Yue Liu wrote: > osx ico

Re: Review Request: Fix icon generation and installation on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/#review23532 --- cmake/modules/KDE4Macros.cmake

Review Request: Fix icon generation and installation on OS X

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107752/ --- Review request for kdelibs. Description --- There are two issues when