Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Thursday 10 March 2011 08:14:04 Dawit A wrote: > On Wed, Mar 9, 2011 at 6:32 PM, Andreas Hartmetz wrote: > > On Wednesday 09 March 2011 23:43:23 Dawit A wrote: > [snipped] > > >> Yes, it is, but not for those reasons. That entry was not put there > >> simply because we had an HTTP proxy imple

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wed, Mar 9, 2011 at 6:32 PM, Andreas Hartmetz wrote: > On Wednesday 09 March 2011 23:43:23 Dawit A wrote: [snipped] >> Yes, it is, but not for those reasons. That entry was not put there >> simply because we had an HTTP proxy implementation, but because FTP >> requests can be routed through an

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wednesday 09 March 2011 23:43:23 Dawit A wrote: > On Wed, Mar 9, 2011 at 2:53 PM, Andreas Hartmetz wrote: > > On Wednesday 09 March 2011 20:06:40 Dawit A wrote: > >> On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: > >> > On Wednesday 09 March 2011, Dawit Alemayehu wrote: > >> >> proxiedBy

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wed, Mar 9, 2011 at 2:53 PM, Andreas Hartmetz wrote: > On Wednesday 09 March 2011 20:06:40 Dawit A wrote: >> On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: >> > On Wednesday 09 March 2011, Dawit Alemayehu wrote: >> >> proxiedBy always returns true since ftp.protocol no longer contains a >

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wednesday 09 March 2011 20:06:40 Dawit A wrote: > On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: > > On Wednesday 09 March 2011, Dawit Alemayehu wrote: > >> proxiedBy always returns true since ftp.protocol no longer contains a > >> "ProxiedBy=" entry. > > > > Yes it does, of course. But t

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wed, Mar 9, 2011 at 12:46 PM, David Faure wrote: > On Wednesday 09 March 2011, Dawit Alemayehu wrote: >> proxiedBy always returns true since ftp.protocol no longer contains a >> "ProxiedBy=" entry. > > Yes it does, of course. But the point of the additional if() is to not go into > that code bl

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

On Wednesday 09 March 2011, Dawit Alemayehu wrote: > proxiedBy always returns true since ftp.protocol no longer contains a > "ProxiedBy=" entry. Yes it does, of course. But the point of the additional if() is to not go into that code block for other procotols, like HTTP, FISH, and so on. > Anyho

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

> On March 7, 2011, 6:26 p.m., David Faure wrote: > > kparts/browserrun.cpp, line 124 > > > > > > For speed reasons, we could do the proxy-determination (which is what > > slaveProtocol does) only for protocols (su

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100814/#review1839 --- Ship it! Thanks. - David On March 8, 2011, 12:43 a.m., Dawit

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100814/ --- (Updated March 8, 2011, 12:43 a.m.) Review request for kdelibs. Changes

Re: Review Request: Fix for connecting to FTP sites through HTTP proxy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100814/#review1832 --- kparts/browserrun.cpp

Review Request: Fix for connecting to FTP sites through HTTP proxy

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100814/ --- Review request for kdelibs. Summary --- The attached patch fixes acce