Re: Review Request: Fix crash in KonqView

2011-11-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103176/#review8287 --- This review has been submitted with commit 71f64e29a072a0da13e1

Re: Review Request: Fix crash in KonqView

2011-11-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103176/#review8286 --- This review has been submitted with commit 96901c51997391b7f6bb

Re: Review Request: Fix crash in KonqView

2011-11-17 Thread Dawit Alemayehu
> On Nov. 17, 2011, 9:28 p.m., Ruurd Pels wrote: > > konqueror/src/konqview.h, line 280 > > > > > > OK I can agree with returning an empty list if m_service == null > > however I also think we need to come up with

Re: Review Request: Fix crash in KonqView

2011-11-17 Thread Ruurd Pels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103176/#review8281 --- Ship it! OK ship it although it might mask off deeper troubles.

Review Request: Fix crash in KonqView

2011-11-17 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103176/ --- Review request for KDE Base Apps and David Faure. Description --- Tho