---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102098/#review5460
---
This review has been submitted with commit
a383ac8c7d3f666018e3
> On July 28, 2011, 10:26 a.m., Aurélien Gâteau wrote:
> > I don't think it is good for unit-tests to test different things depending
> > on environment variables (
> > @David, what is your opinion on the subject?)
> >
> > I was actually about to commit a simpler fix:
> >
> > @@ -26,11 +26,11
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102098/#review5311
---
This review has been submitted with commit
1b9f388c739e7595e652
> On July 28, 2011, 10:26 a.m., Aurélien Gâteau wrote:
> > I don't think it is good for unit-tests to test different things depending
> > on environment variables (
> > @David, what is your opinion on the subject?)
> >
> > I was actually about to commit a simpler fix:
> >
> > @@ -26,11 +26,11
> On July 28, 2011, 10:26 a.m., Aurélien Gâteau wrote:
> > I don't think it is good for unit-tests to test different things depending
> > on environment variables (
> > @David, what is your opinion on the subject?)
> >
> > I was actually about to commit a simpler fix:
> >
> > @@ -26,11 +26,11
> void KGlobalSettingsTest::initTestCase()
> {
> +// Some signals are only emitted when we are running a full KDE
> session. If
> +// we are not then KDE applications follow the platform palette and
> font
> +// settings.
> +setenv("KDE_FULL_SESSION", "1", 1);
> +
qputenv()?
Eik
> On July 28, 2011, 10:26 a.m., Aurélien Gâteau wrote:
> > I don't think it is good for unit-tests to test different things depending
> > on environment variables (
> > @David, what is your opinion on the subject?)
> >
> > I was actually about to commit a simpler fix:
> >
> > @@ -26,11 +26,11
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102098/#review5166
---
I don't think it is good for unit-tests to test different things
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102098/
---
Review request for kdelibs, Aurélien Gâteau and David Faure.
Summary
-
