Re: Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-07-18 Thread Jeremy Paul Whiting
> On June 1, 2011, 8:44 p.m., Christoph Feck wrote: > > Looks good, thanks. > > Christoph Feck wrote: > Actually, the same change/fix needs to be made to > KConfigDialogManager::setProperty() Good catch. Ok, will do. I'll make the fix on 4.7 and master branches. - Jeremy Paul -

Re: Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-07-18 Thread Christoph Feck
> On June 1, 2011, 8:44 p.m., Christoph Feck wrote: > > Looks good, thanks. Actually, the same change/fix needs to be made to KConfigDialogManager::setProperty() - Christoph --- This is an automatically generated e-mail. To reply, visi

Re: Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/#review3937 --- This review has been submitted with commit 8edc1932ecc62370d9a3

Re: Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-06-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/#review3620 --- This review has been submitted with commit d44186bce4670d2985fb

Re: Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-06-01 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/#review3619 --- Ship it! Looks good, thanks. - Christoph On June 1, 2011, 7:

Review Request: Fix KComboBox KConfigXT bug when using qt 4.8

2011-06-01 Thread Jeremy Paul Whiting
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101486/ --- Review request for kdelibs and Eike Hein. Summary --- QComboBox in qt