Re: Review Request: Fix KCategorizedView race

2011-12-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8834 --- This review has been submitted with commit 8095c11d181e967cb161

Re: Review Request: Fix KCategorizedView race

2011-12-09 Thread Thomas Lübking
> On Dec. 9, 2011, 8:46 a.m., Jaime Torres Amate wrote: > > It works for me. You have my ship it. If nobody else has a comment and since it's confirmed by Jaime and myself to be better than the current state, i'll push this 21:00 CET - so shout HOLD right now ;-) - Thomas -

Re: Review Request: Fix KCategorizedView race

2011-12-09 Thread Jaime Torres Amate
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8815 --- It works for me. You have my ship it. - Jaime Torres Amate On

Re: Review Request: Fix KCategorizedView race

2011-12-08 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/ --- (Updated Dec. 8, 2011, 6:04 p.m.) Review request for kdelibs, Rafael Ferná

Re: Review Request: Fix KCategorizedView race

2011-12-08 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8803 --- kdeui/itemviews/kcategorizedview.cpp

Re: Review Request: Fix KCategorizedView race

2011-12-08 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8802 --- - Thomas Lübking On Dec. 8, 2011, 6:04 p.m., Thomas Lübking wr

Re: Review Request: Fix KCategorizedView race

2011-12-08 Thread Thomas Lübking
Am Thu, 8 Dec 2011 07:59:43 -0800 schrieb Tomaz Canabrava : > What about jaime patch? yeah, static policies work - we know that ;-) This one is quite different (recursion, not race - though maybe both), from the first rough look there seem two recursions, one direct (easy to catch) and one throug

Re: Review Request: Fix KCategorizedView race

2011-12-08 Thread Tomaz Canabrava
On Thu, Dec 8, 2011 at 2:33 AM, Thomas Lübking wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103335/ > > On December 6th, 2011, 6:39 p.m., *Commit Hook* wrote: > > This review has been submitted with commit > 08325ba32b72326030004cc2843

Re: Review Request: Fix KCategorizedView race

2011-12-08 Thread Thomas Lübking
> On Dec. 6, 2011, 6:39 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 08325ba32b72326030004cc28430431193d82fc2 by Thomas Lübking to branch > > KDE/4.7. > > Christoph Feck wrote: > This commit causes systemsettings to go into endless recursion, see > http://pr

Re: Review Request: Fix KCategorizedView race

2011-12-08 Thread Jaime
The new endless loop (causing a stack overflow here when I resize systemsettings view) this time is in: QListView::resizeEvent(QResizeEvent *e) that calls QAbstractItemView::resizeEvent(e); QAbstractItemView::resizeEvent(QResizeEvent *event) that calls KCategorizedView::updateGeometries(); QFra

Re: Review Request: Fix KCategorizedView race

2011-12-08 Thread Christoph Feck
> On Dec. 6, 2011, 6:39 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 08325ba32b72326030004cc28430431193d82fc2 by Thomas Lübking to branch > > KDE/4.7. This commit causes systemsettings to go into endless recursion, see http://privatepaste.com/0e43ad214c zemo on

Re: Review Request: Fix KCategorizedView race

2011-12-06 Thread Aaron J. Seigo
> On Dec. 6, 2011, 2:07 p.m., Aaron J. Seigo wrote: > > Ship It! > > Thomas Lübking wrote: > What's the policy for merging things into the frameworks branch? > - Merge? > - Cherry-pick? > - Have someone else do it anyway? we merge KDE/4.7 into frameworks every so often. i did it

Re: Review Request: Fix KCategorizedView race

2011-12-06 Thread Thomas Lübking
> On Dec. 6, 2011, 2:07 p.m., Aaron J. Seigo wrote: > > Ship It! What's the policy for merging things into the frameworks branch? - Merge? - Cherry-pick? - Have someone else do it anyway? - Thomas --- This is an automatically generated

Re: Review Request: Fix KCategorizedView race

2011-12-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8765 --- This review has been submitted with commit 08325ba32b7232603000

Re: Review Request: Fix KCategorizedView race

2011-12-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8750 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 5, 2011, 2:21 p.m

Review Request: Fix KCategorizedView race

2011-12-05 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/ --- Review request for kdelibs, Rafael Fernández López and Jaime Torres Amate.