Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Dawit Alemayehu
> On Feb. 20, 2011, 10:20 p.m., Dawit Alemayehu wrote: > > kioslave/http/http.cpp, line 4059 > > > > > > The size variable here needs to be qint64. Oh, just in case you are not already aware, please use "REVIEW:1006

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/#review1538 --- Ship it! Looks good, but make sure you fix the issue I pointed

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Grégory Oestreicher
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/ --- (Updated Feb. 20, 2011, 10:03 p.m.) Review request for kdelibs. Changes

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Sergio Luis Martins
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/#review1537 --- kio/kio/davjob.cpp

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Grégory Oestreicher
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/ --- (Updated Feb. 20, 2011, 9:48 p.m.) Review request for kdelibs. Changes -

Re: Review Request: Fix DAV jobs bug

2011-02-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/#review1535 --- Except for the inconsistency of using "int" for the size value o

Review Request: Fix DAV jobs bug

2011-02-20 Thread Grégory Oestreicher
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100694/ --- Review request for kdelibs. Summary --- Following commit 01db8ec6e993