Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-12-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review23352 --- kioslave/trash/kio_trash.cpp

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-12-12 Thread Michael Reeves
> On Dec. 11, 2012, 4:26 p.m., David Faure wrote: > > kioslave/trash/kio_trash.cpp, line 72 > > > > > > Hmm did you test this change ? :) > > > > A "return fileDisplayName;" is missing here, so basically >

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-12-12 Thread Michael Reeves
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/ --- (Updated Dec. 11, 2012, 9:51 p.m.) Review request for KDE Runtime. Chang

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-12-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review23317 --- kioslave/trash/kio_trash.cpp

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-12-11 Thread Michael Reeves
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/ --- (Updated Dec. 11, 2012, 7:04 a.m.) Review request for KDE Runtime. Chang

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-11-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review22311 --- Ship it! Starting to look good :-) Just one minor code issue,

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-11-16 Thread Michael Reeves
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/ --- (Updated Nov. 16, 2012, 2:19 a.m.) Review request for KDE Runtime. Chang

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-11-12 Thread Michael Reeves
> On Nov. 10, 2012, 9:36 p.m., David Faure wrote: > > kioslave/trash/kio_trash.cpp, line 277 > > > > > > Sorry for the time it took me to review this proposed change. > > > > It turns out that this change b

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-11-10 Thread David Faure
> On June 19, 2012, 5:55 a.m., David Faure wrote: > > Good idea, but it seems to break the case where nested dirs exist in the > > directory being restored. Everything gets flattened out. Probably a bug in > > CopyJob though, in the handling of fileNameUsedForCopying=DisplayName > > Michael Re

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-11-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review21782 --- kioslave/trash/kio_trash.cpp

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-07-03 Thread Michael Reeves
> On June 19, 2012, 5:55 a.m., David Faure wrote: > > Good idea, but it seems to break the case where nested dirs exist in the > > directory being restored. Everything gets flattened out. Probably a bug in > > CopyJob though, in the handling of fileNameUsedForCopying=DisplayName > > Michael Re

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-06-19 Thread Michael Reeves
> On June 19, 2012, 5:55 a.m., David Faure wrote: > > Good idea, but it seems to break the case where nested dirs exist in the > > directory being restored. Everything gets flattened out. Probably a bug in > > CopyJob though, in the handling of fileNameUsedForCopying=DisplayName >From what I c

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-06-18 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/#review14874 --- Good idea, but it seems to break the case where nested dirs exi

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-06-18 Thread Michael Reeves
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/ --- (Updated June 18, 2012, 5:39 p.m.) Review request for KDE Runtime. Chang

Re: Review Request: Don't append "0-" when dragging and dropping from trash

2012-05-28 Thread Michael Reeves
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/ --- (Updated May 28, 2012, 5:57 p.m.) Review request for KDE Runtime. Descri

Review Request: Don't append "0-" when dragging and dropping from trash

2012-05-28 Thread Michael Reeves
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105078/ --- Review request for KDE Runtime. Description --- This patch makes drag