Re: Review Request: Dolphin details view optimization

2011-05-25 Thread Christoph Feck
> On March 10, 2011, 8:05 a.m., Peter Penz wrote: > > Thanks a lot for this good patch, please commit :-) Would also be great if > > this could be backported to 4.6.2. > > Peter Penz wrote: > I've committed the patch and backported it to 4.6. Samuel, can you close this as submitted? - Ch

Re: Review Request: Dolphin details view optimization

2011-03-12 Thread Peter Penz
> On March 10, 2011, 8:05 a.m., Peter Penz wrote: > > Thanks a lot for this good patch, please commit :-) Would also be great if > > this could be backported to 4.6.2. I've committed the patch and backported it to 4.6. - Peter --- This

Re: Review Request: Dolphin details view optimization

2011-03-10 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100826/#review1874 --- dolphin/src/views/dolphinfileitemdelegate.h

Re: Review Request: Dolphin details view optimization

2011-03-10 Thread Milian Wolff
> On March 10, 2011, 12:03 a.m., Thomas Lübking wrote: > > dolphin/src/views/dolphinfileitemdelegate.h, line 40 > > > > > > You could probably avoid the QObject inheritance and just add an > > ordinary function and

Re: Review Request: Dolphin details view optimization

2011-03-10 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100826/#review1879 --- Ship it! Thanks a lot for this good patch, please commit :-) Wo

Re: Review Request: Dolphin details view optimization

2011-03-09 Thread Samuel Rødal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100826/ --- (Updated March 9, 2011, 11:38 p.m.) Review request for KDE Base Apps. Ch

Re: Review Request: Dolphin details view optimization

2011-03-09 Thread Samuel Rødal
> On March 9, 2011, 10:40 p.m., Christoph Feck wrote: > > Does it handle color changes made by the user? > > Milian Wolff wrote: > it won't. > > @Samuel: connecting to this signal (and recomputing the color) should > help with this > http://api.kde.org/4.x-api/kdelibs-apidocs/kdeu

Re: Review Request: Dolphin details view optimization

2011-03-09 Thread Milian Wolff
> On March 9, 2011, 10:40 p.m., Christoph Feck wrote: > > Does it handle color changes made by the user? it won't. @Samuel: connecting to this signal (and recomputing the color) should help with this http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKGlobalSettings.html#a4a8de991c8e2

Re: Review Request: Dolphin details view optimization

2011-03-09 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100826/#review1870 --- Does it handle color changes made by the user? - Christoph On

Review Request: Dolphin details view optimization

2011-03-09 Thread Samuel Rødal
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100826/ --- Review request for KDE Base Apps. Summary --- Constructing a KColorSc