Re: Review Request: Consider data: URLs local in KIO::AccessManager

2011-04-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101140/#review2700 --- This review has been submitted with commit be0cc2198d3c59569705

Re: Review Request: Consider data: URLs local in KIO::AccessManager

2011-04-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101140/#review2699 --- This review has been submitted with commit a3297d274843c22ee8f5

Re: Review Request: Consider data: URLs local in KIO::AccessManager

2011-04-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101140/#review2686 --- Ship it! Hmm... did not know KUrl::protocol() already returned

Re: Review Request: Consider data: URLs local in KIO::AccessManager

2011-04-16 Thread Volker Krause
> On April 16, 2011, 4:45 p.m., Kevin Krammer wrote: > > Wouldn't it make more sense to change KProtocolInfo::protocolClass() such > > that it considers data: to be local access? > > Volker Krause wrote: > That was indeed my first attempt, but David pointed out that this would > have furth

Re: Review Request: Consider data: URLs local in KIO::AccessManager

2011-04-16 Thread Dawit Alemayehu
> On April 16, 2011, 4:45 p.m., Kevin Krammer wrote: > > Wouldn't it make more sense to change KProtocolInfo::protocolClass() such > > that it considers data: to be local access? > > Volker Krause wrote: > That was indeed my first attempt, but David pointed out that this would > have furth

Re: Review Request: Consider data: URLs local in KIO::AccessManager

2011-04-16 Thread Volker Krause
> On April 16, 2011, 4:45 p.m., Kevin Krammer wrote: > > Wouldn't it make more sense to change KProtocolInfo::protocolClass() such > > that it considers data: to be local access? That was indeed my first attempt, but David pointed out that this would have further (security) implications, since

Re: Review Request: Consider data: URLs local in KIO::AccessManager

2011-04-16 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101140/#review2680 --- Wouldn't it make more sense to change KProtocolInfo::protocolCla

Review Request: Consider data: URLs local in KIO::AccessManager

2011-04-16 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101140/ --- Review request for kdelibs. Summary --- Currently KIO::AccessManager