Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20640 --- This review has been submitted with commit 0b8942128aafe59d7ff

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20612 --- Almost there ;) Feel free to commit after fixing these last sma

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 16, 2012, 4:22 p.m.) Review request for kdelibs and David Fa

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
> On Oct. 16, 2012, 3:39 p.m., David Faure wrote: > > kio/kio/kfileitem.cpp, line 515 > > > > > > kdelibs coding style says this should be on the same line as the if(). The whole file has braces on new line, so to

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20459 --- kio/kio/kfileitem.cpp

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 16, 2012, 4:15 p.m.) Review request for kdelibs and David Fa

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20456 --- kio/kio/kfileitem.cpp

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 16, 2012, 2:43 p.m.) Review request for kdelibs and David Fa

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/#review20450 --- kio/kio/kfileitem.cpp

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 15, 2012, 10:15 p.m.) Review request for kdelibs and David F

Re: Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- (Updated Oct. 15, 2012, 7:52 p.m.) Review request for kdelibs and David Fa

Review Request: Check KFileItem d pointer for validity in KFileItem methods

2012-10-15 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106902/ --- Review request for kdelibs and David Faure. Description --- Check the